Skip to content

[Subcontracting] Disable "WIP Item Transfer" for Machine Center#8747

Open
SPinkow wants to merge 2 commits into
microsoft:mainfrom
GOB-Software-Systeme-DevOps:w/pinkow/Issue36_EditabilityOfWIPItemFields
Open

[Subcontracting] Disable "WIP Item Transfer" for Machine Center#8747
SPinkow wants to merge 2 commits into
microsoft:mainfrom
GOB-Software-Systeme-DevOps:w/pinkow/Issue36_EditabilityOfWIPItemFields

Conversation

@SPinkow

@SPinkow SPinkow commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What & why

This pull request introduces stricter validation and improved UI logic for the "Transfer WIP Item" field on routing lines, ensuring that this field is only enabled and valid for "Work Center" type routing lines with subcontracting enabled. It also adds comprehensive automated UI and validation tests to guarantee correct behavior, and refactors some test utilities for better coverage and maintainability.

Validation and UI logic improvements:

  • The "Transfer WIP Item" field is now only enabled and valid for routing lines of type "Work Center" with subcontracting enabled; it is disabled and validation fails for "Machine Center" types. [1] [2] [3]
  • The "Transfer WIP Item" field is explicitly set as non-editable and invisible in the Subc. PO Subform page extension.

Automated test coverage:

  • Added multiple UI and validation tests in Subc. Subcontracting UI Test to verify that the "Transfer WIP Item" field is only enabled for eligible Work Center lines and not for Machine Center lines, and that validation fails if incorrectly set.

Test utility enhancements:

  • Introduced a new CreateRoutingLineForMachineCenter helper in the manufacturing management test library to streamline test setup for Machine Center routing lines, and made CreateRoutingLine public for broader utility. [1] [2]
  • Added necessary codeunit references and error labels to support the new test scenarios. [1] [2]

Linked work

Fixes AB#640173

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
Added Tests and do a manual validation in client

Risk & compatibility

None

@SPinkow SPinkow requested a review from a team June 23, 2026 14:19
@github-actions github-actions Bot added needs-approval Workflow runs require maintainer approval to start AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork labels Jun 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

@SPinkow SPinkow changed the title Disable "WIP Item Transfer" for Machine Center [Subcontracting] Disable "WIP Item Transfer" for Machine Center Jun 23, 2026
@alexei-dobriansky alexei-dobriansky enabled auto-merge (squash) June 23, 2026 14:29
@github-actions github-actions Bot added Linked Issue is linked to a Azure Boards work item and removed needs-approval Workflow runs require maintainer approval to start labels Jun 23, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jun 23, 2026
@ChethanT ChethanT added the Subcontracting Subcontracting related activities label Jun 23, 2026
@JesperSchulz JesperSchulz added the SCM GitHub request for SCM area label Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item SCM GitHub request for SCM area Subcontracting Subcontracting related activities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants